test: add coverage to dgram receive error case #11241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Feb 8, 2017
hiroppy
approved these changes
Feb 9, 2017
This commit adds coverage for the case where a dgram socket handle receives a message, but nread < 0, indicating an error. PR-URL: nodejs#11241 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
italoacasas
pushed a commit
that referenced
this pull request
Feb 13, 2017
This commit adds coverage for the case where a dgram socket handle receives a message, but nread < 0, indicating an error. PR-URL: #11241 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 14, 2017
This commit adds coverage for the case where a dgram socket handle receives a message, but nread < 0, indicating an error. PR-URL: nodejs#11241 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
krydos
pushed a commit
to krydos/node
that referenced
this pull request
Feb 25, 2017
This commit adds coverage for the case where a dgram socket handle receives a message, but nread < 0, indicating an error. PR-URL: nodejs#11241 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
|
Depends on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds coverage for the case where a dgram socket
handle receives a message, but
nread< 0, indicating an error.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test